session.js/client
1
0
Fork 0
Code Issues 1 Pull requests Activity

Polling / sending to closed group doesn't work #3

New issue
Open
opened 2024-11-27 08:10:52 +01:00 by olpalu · 7 comments
olpalu commented 2024-11-27 08:10:52 +01:00 (Migrated from github.com)
Copy link

The polling and sending features to closed groups in Session are not functioning as expected. The example provided here does not work for closed groups. By "closed groups," I am referring to the private groups created within Session, which support a maximum of 100 people.

The polling and sending features to closed groups in Session are not functioning as expected. The example provided [here](https://sessionjs.github.io/docs/polling/) does not work for closed groups. By "closed groups," I am referring to the [private groups](https://getsession.org/faq#closed-groups) created within Session, which support a maximum of 100 people.
VityaSchel commented 2024-11-27 08:58:17 +01:00 (Migrated from github.com)
Copy link

Hi! I know this feature wasn't implemented yet. This was initially pending until Session developers team rewrite closed chats backend, but now the whole library development is frozen until they move all stuff to libsession and then this library will be backed by it instead of manually handling connections.
You can always, of course, contact me if you want to pay me to work on this, but I'm currently a little busy with a lot of orders from Session community

Hi! I know this feature wasn't implemented yet. This was initially pending until Session developers team rewrite closed chats backend, but now the whole library development is frozen until they move all stuff to libsession and then this library will be backed by it instead of manually handling connections. You can always, of course, contact me if you want to pay me to work on this, but I'm currently a little busy with a lot of orders from Session community
VityaSchel commented 2024-11-27 08:58:46 +01:00 (Migrated from github.com)
Copy link

PRs are welcome, too :)

PRs are welcome, too :)
olpalu commented 2024-11-27 09:52:10 +01:00 (Migrated from github.com)
Copy link

If you could provide guidance on what changes should be made, I may be able to work on that.

If you could provide guidance on what changes should be made, I may be able to work on that.
VityaSchel commented 2024-11-27 10:14:57 +01:00 (Migrated from github.com)
Copy link

You should start by figuring out how sending messages work in Session and especially in current closed groups implementation. Dig official electron desktop client or any other implementation that feels closer to your skills. Then look for sending messages script in this library and implement section for closed groups

You should start by figuring out how sending messages work in Session and especially in current closed groups implementation. Dig official electron desktop client or any other implementation that feels closer to your skills. Then look for sending messages script in this library and implement section for closed groups
olpalu commented 2024-11-27 10:23:31 +01:00 (Migrated from github.com)
Copy link

ok, how to groupPubKey here
is it something that we should provide like sessionID ?

ok, how to groupPubKey [here](https://github.com/sessionjs/client/blob/4550377a44c10cc2ea122bbea4bf953a1714900d/src/polling/index.ts#L182) is it something that we should provide like sessionID ?
VityaSchel commented 2024-11-27 10:28:05 +01:00 (Migrated from github.com)
Copy link

This was taken from official desktop client code, so I suggest looking there

This was taken from official desktop client code, so I suggest looking there
VityaSchel commented 2024-11-27 13:31:55 +01:00 (Migrated from github.com)
Copy link

also rate my session merch btw IMG_20241127_125640_837.jpg

also rate my session merch btw ![IMG_20241127_125640_837.jpg](https://github.com/user-attachments/assets/88e6d7d1-879a-4110-9d8a-79a353c79594)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: session.js/client#3
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?