Support for native events on video, dispatch to redux when event happens on video ref, not on specific action #5

New issue

Closed

opened 2022-07-19 13:27:01 +02:00 by VityaSchel · 0 comments

VityaSchel commented

2022-07-19 13:27:01 +02:00

(Migrated from github.com)

Describe the bug
Imagine some user has a binding that muted/unmutes video in web browser. Currently redux state is updated when user presses mute/unmute button. On click event, components changes property in player and dispatches to redux. This way, redux will never change its state if user muted video not using this button.

Expected behavior
It's better to dispatch thunks to redux from native video events (such as onVolumeChange) so every change (including component's changes to player instance) will be recorded and rendered.

**Describe the bug** Imagine some user has a binding that muted/unmutes video in web browser. Currently redux state is updated when user presses mute/unmute button. On click event, components changes property in player and dispatches to redux. This way, redux will never change its state if user muted video not using this button. **Expected behavior** It's better to dispatch thunks to redux from native video events (such as onVolumeChange) so every change (including component's changes to player instance) will be recorded and rendered.